On 7/11/2012 11:40 AM, Alex Jia wrote: > On 07/11/2012 10:39 AM, Yu Mingfei wrote: >> On 7/10/2012 11:44 PM, Alex Jia wrote: >>> As I said, virsh domname case should receive different id or uuid >>> rather than different domain name, so I thinks it's irrelevant with >>> this case. >> I will discuss with my partner.Thanks for your comment.^^ >> >>> >>> In addition, as we discussed, if you want to operate XML, you should >>> spit it into libvirt_xml relevant module, I think it should be common >>> function for XML's adding, deleting, searching, modifying. >> I have thought about it. >> But I do not know where I should put rename_xml_utils() in. >> If you have idea about it, tell me please.^_^ > > It should be common class or function for guest, network, storage, etc > XML configuration adding/deleting/searching/modifying, for example: > > class VMXmlUtils(): > def __init__(self, vm_xml): > self.xml = vm_xml > > def add(self, cxt): > XXXXXXX > > def delete(self, cxt): > XXXXXXX > > def search(self, cxt): > XXXXXXX > > def modify(self, cxt): > XXXXXXX > > class NetworkXmlUtils(): > XXXXXX > > Of course, it's just my thought, maybe, other guys have better idea or > advise. Good idea. But I remember that Chris has sent a patch about Enhancements for xml_utils & unittest. [The email on 6/29][PATCH] Client: Enhancements for xml_utils & unittest It seems that we can use xml_utils & unittest directly,But It hasn't been finished. And I concern that it may confict with this work. What do you think of this problem?^_^
> >> >> BTW, do you have objection with vm.rename()? > > vm.rename() is fine for me, It just is irrelevant with this case. > >> I will use it in later patchs, for example, virsh schedinfo <vm_name >> or id>. >> vm_name will be changed to different type for command "virsh >> schedinfo"'s test. > > could you explain more? I think it should be different guest, if you > just rename guest without modifying others then virsh schedinfo will get > the same 'cpu_shares', 'vcpu_period' and 'vcpu_quota'. if you want to > change guest relevant XML configuration without any affect on guest, > maybe, snapshot or clone is a good idea. What do you think? In fact, we focus on options of "virsh schedinfo", But not different guest has different value of virsh schedinfo. What we need to test is whether it can work well when we execute "virsh schedinfo" with different type guest name. So we think snapshot or clone is no necessary and takes too much time. > >> >>> >>> Alex _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
