On 07/13/2012 02:10 PM, Yu Mingfei wrote: > On 7/11/2012 11:40 AM, Alex Jia wrote: >> On 07/11/2012 10:39 AM, Yu Mingfei wrote: >>> On 7/10/2012 11:44 PM, Alex Jia wrote: >>>> As I said, virsh domname case should receive different id or uuid >>>> rather than different domain name, so I thinks it's irrelevant with >>>> this case. > I think rename() is necessary to test domname.
Not necessary. > Although domname just receives id/uuid as options, but the output has > only a domain's name, > So we should check its result. > Our consideration is whether result we got from domname command is > expected when doman's name is different type. > What do you thinks about it? > Please refer to the following uuid test case from libvirt upstream, it should give you some hints and clue: http://libvirt.org/git/?p=libvirt.git;a=blob;f=python/tests/uuid.py;h=db48e808152391ef606d22a788c9b514c27ec995;hb=HEAD >>> >>>> >>>> In addition, as we discussed, if you want to operate XML, you should >>>> spit it into libvirt_xml relevant module, I think it should be common >>>> function for XML's adding, deleting, searching, modifying. >>> I have thought about it. >>> But I do not know where I should put rename_xml_utils() in. >>> If you have idea about it, tell me please.^_^ >> > _______________________________________________ Autotest mailing list Autotest@test.kernel.org http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
