Re: cornerstone updates

[Stephen McConnell]

Peter M. Goldstein wrote:

Steve,

2. DefaultConnectionManager - updated sources so that it doesn't throw
an
exception when disconnecting an unknown connection (James is
disconnecting
twice and the second time is resulting in an
IllegalArgumentException. I've
made a minor update that basically returns if the supplied
connection is
unknown).

More out of curiosity than anything else, why was this change necessary?

During test I discovered that James was logging a disposal error resulting from releasing the ports for the SMTP, POP3 and Remote Admin services during the sutdown phase. I checked the cause ant it was that the disconnect was being invoked twice. I didn't dig into why.

Was this a Merlin thing?

Don't think - but it could be an assembly description thing - i.e. the assembly defintion I'm using could be out of date.

In the standard Phoenix-based configuration, James
doesn't even use DefaultConnectionManager.  There is a specific
ConnectionManager implementation -
org.apache.james.util.connection.SimpleConnectionManager - that is used
instead.  In theory one could use DefaultConnectionManager, but I don't see
why one would, as it lacks some of the connection throttling features of the
James class.

I noticed the class a couple of hours ago.

OK - the assembly definition I'm using does not declare the connection service - so what is happening is that Merlin is figuring out that this service is needed, locates all of the candidate compoennt providers, selects one and assigns it on demand. As it turns out, Merlin is selecting the cornerstone connection service - however, I've just added a declaration of the James implemetation - and because its an explicit declaration - the James component will take priority during selection.

Which then raises the question - why are the connection being disconnect twice?
I'll do some digging.

Cheers, Steve.

p.s. Are the enhancements to the James version of the conection servicve appropriate for back porting into the Conerstone verion?

SJM

--

Stephen J. McConnell
mailto:[EMAIL PROTECTED]
http://www.osm.net




--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>