Stephen McConnell wrote:
Sylvain Wallez wrote:Stephen McConnell wrote:Marcus Crafter wrote:Hi All,
Hope all is well.
Does anyone see any problems if I go ahead and commit this patch
from Sylvain - I saw some posts about releasing logkit earlier in
the month so I'm just wondering if we should put this is into logkit
now or after the release goes through ?
Hi Markus:
I keen to see this inside logkit - but I think it should be packaged as a seperate jar (even if it is three small classes). Reason being that I prefer to keep logkit as small as possible.
There's already some Servlet, JDBC and JMS stuff in logkit. Does these _two_ classes (the third one is in excalibur-logger) hurt ?
Not really - its not big thing. I havn't looked at the sources in question - just working on the principal of seperating the core logkit package from a tool related to the package. Why? Because I'm interested in the subject and would dig into this some more at some point in the future.
If yes, then where should they be located ? In excalibur-logger ? But there are currently only TargetFactories here...
I'm happy to go with whatever you think is best.
So let's put all this in excalibur.logger.factory. This package was created to avoid dependencies of LogKit on the framework, so this seems to be a good place.
Should I resubmit an updated patch ?
Sylvain
--
Sylvain Wallez Anyware Technologies
http://www.apache.org/~sylvain http://www.anyware-tech.com
{ XML, Java, Cocoon, OpenSource }*{ Training, Consulting, Projects }
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
