Hi,

> > btw i must keep the wrappers, as libwin32.h and the lots of stuff included
> > there does conflicts with other includes in mplayer. :(
> > but it's my prob...
> 
> libwin32.h should be eliminated - passed structure will be pointers to
> BITMAPINFOHEADER and other standard Win32 structure 
ok

> (BTW wine/ have no __atribute__ for packing - they have been producing
> somewhat incorrect sizeof result :)
i know. see my version :)

> > it's coding style so you'll rewrite it :), but in its current state it is
> > working well and provides an array of codecs with all info parsed from
> > the codecs.conf file. some things can be removed, mainly the native codec
> > ids. it's enough to keep acm/vfw and dshow types, and maybe qtx in the
> > future.
> 
> we will see - but I have some more needs
tell me them.

> > like cram and huffyuv (their outfmt depends on input bitmapinfohdr).
> > but on the other side, soem codecs provides false info at detection.
> 
> thats why there are workaround - when codes does something wrong - it's
> fixed so the outside result shuold be always correct.
it's ok. but tehse workarounds should be controlled via the config file, or
the config file has no sense at all. having dll names hardcoded into
workaround code makes codecs.conf nonsense. then hardcode all, dll names,
guids etc. or put all to codecs.conf.

this is what i hate and don't want to see in the future:
        this->m_bIsDivX = (strcmp((const char*)info->dll, "divxcvki.ax") ==
0
                     || strcmp((const char*)info->dll, "divx_c32.ax") == 0
                     || strcmp((const char*)info->dll, "wmvds32.ax") == 0
                     || strcmp((const char*)info->dll, "wmv8ds32.ax") == 0);
        this->m_bIsDivX4 = (strcmp((const char*)info->dll, "divxdec.ax") ==
0);

...
        switch (this->iv.m_bh->biCompression)
        {
        case fccDIV3:
        case fccDIV4:
        case fccDIV5:
        case fccDIV6:
        case fccMP42:
        case fccWMV2:
...

don't tell me it's clean this way...


A'rpi / Astral & ESP-team

--
mailto:[EMAIL PROTECTED]
http://esp-team.scene.hu

_______________________________________________
Avifile mailing list
[EMAIL PROTECTED]
http://prak.org/mailman/listinfo/avifile

Reply via email to