On 09/11/2017 10:21 AM, Lucas Meneghel Rodrigues wrote: > > > On Mon, Sep 11, 2017 at 10:23 AM Lukáš Doktor <[email protected] > <mailto:[email protected]>> wrote: > > Hello Guannan, > > theoretically we should not accept such backport, because it's a new > feature, not a bugfix. Anyway it touches `avocado.utils` and it's > not changing existing callbacks. What do you think, guys? In my view > the `avocado/core` is the core and I wouldn't like such changes > there, but I'd be fine with some exceptions when it goes to > `avocado/utils`. > > > I believe we should stick to the established policy. Guannan should be > able to put the needed backported functions into a testing specific > library, until he can move away from 36lts. > >
Even before looking at the code that was requested to be backported, I agreed with this. I mean, if the requested backport was such that did not quite fit the bug description, but was one that was hard to work around without a backport, I'd be tempted to accept an exception to the policy. But this is not the case. IIUC, this is about avocado.utils.cpu.cpu_online_list(), a self contained, 5-liner function, that can easily be carried around with the test code. Guannan, Sorry, but we'll have to NACK this request of yours. Thanks! - Cleber. > Lukáš > > Dne 8.9.2017 v 08:41 Guannan Sun napsal(a): > > Hi, > > > > As RHEL6 still need use 36lts, and cases updated with using the > function in > > PR 1376: > > > > https://github.com/avocado-framework/avocado/pull/1376 > > > > could you help backport the commits to 36lts? > > > > Thanks! > > Guannan > > > > -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ] [ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]
signature.asc
Description: OpenPGP digital signature
