[ 
https://issues.apache.org/jira/browse/AVRO-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744664#action_12744664
 ] 

Doug Cutting commented on AVRO-95:
----------------------------------

> it's a bit icky that changes to the list passed in effect the writing.

I agree, but that's a more systemic problem.  None of Schema's constructors 
copy data passed in.  The current style is leave that to applications -- folks 
shouldn't generally modify data after passing it to a Schema constructor.  
Changing that may have performance implications, and should be done thoroughly 
rather than piecemeal.  But adding to a union is generally harmless.

I'll commit this as-is unless there are objections.


> mixing multiple types in one data file using reflection is not supported
> ------------------------------------------------------------------------
>
>                 Key: AVRO-95
>                 URL: https://issues.apache.org/jira/browse/AVRO-95
>             Project: Avro
>          Issue Type: Bug
>          Components: java
>    Affects Versions: 1.0.0
>            Reporter: Eelco Hillenius
>            Assignee: Doug Cutting
>             Fix For: 1.0.1
>
>         Attachments: AVRO-95.patch, AVRO-95.patch, AVRO-95.patch, 
> AVRO-95.patch, AVRO-95.patch, AVRO-95.patch
>
>
> My use case is that I have a bunch of different kind of events (in a 
> hierarchy actually, which right now isn't supported either, see AVRO-93), 
> that I would like to write out to log files using Avro. Unfortunately, 
> writing more than one type via reflection seems to be broken currently. I 
> think I can tell from the code and the resulting data file that this should 
> be supported, but it seems that there are a few issues with the 
> implementation right now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to