[ 
https://issues.apache.org/jira/browse/AVRO-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765219#action_12765219
 ] 

Doug Cutting commented on AVRO-142:
-----------------------------------

For the changes to TestCompare to be maintainable, we should start running 
checkstyle on the test code tree.  Would you like to make that change too?

> Removing unused fields, constructors, and imports
> -------------------------------------------------
>
>                 Key: AVRO-142
>                 URL: https://issues.apache.org/jira/browse/AVRO-142
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>            Priority: Minor
>         Attachments: AVRO-142.patch.text
>
>
> The patch to follow removes some unused fields.  I've been setting up Eclipse 
> to work on Avro (patch forthcoming), and Eclipse is perhaps unreasonably 
> whiny about these things, but there were so few, that it seemed harmless to 
> fix them.
> DataFileReader had a "count" field, which was never read (only assigned), so 
> I've deleted it.
> Several classes had LOG fields that were never used; I deleted them.
> TestCompare had a handful of unused imports; just deleted them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to