[ 
https://issues.apache.org/jira/browse/AVRO-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765705#action_12765705
 ] 

Doug Cutting commented on AVRO-142:
-----------------------------------

After applying this, 'ant clean test' fails for me with:

{noformat}
checkstyle-java:
[checkstyle] Running Checkstyle 5.0 on 102 files
[checkstyle] 
/home/cutting/src/avro/trunk/src/test/java/org/apache/avro/TestBulkData.java:22:
 Using the '.*' form of import should be avoided - org.apache.avro.ipc.*.
[checkstyle] 
/home/cutting/src/avro/trunk/src/test/java/org/apache/avro/TestBulkData.java:23:
 Using the '.*' form of import should be avoided - org.junit.*.
BUILD FAILED
{noformat}



> Removing unused fields, constructors, and imports
> -------------------------------------------------
>
>                 Key: AVRO-142
>                 URL: https://issues.apache.org/jira/browse/AVRO-142
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>            Priority: Minor
>         Attachments: AVRO-142.patch.text, AVRO-142.patch.v2.txt
>
>
> The patch to follow removes some unused fields.  I've been setting up Eclipse 
> to work on Avro (patch forthcoming), and Eclipse is perhaps unreasonably 
> whiny about these things, but there were so few, that it seemed harmless to 
> fix them.
> DataFileReader had a "count" field, which was never read (only assigned), so 
> I've deleted it.
> Several classes had LOG fields that were never used; I deleted them.
> TestCompare had a handful of unused imports; just deleted them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to