[
https://issues.apache.org/jira/browse/AVRO-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. updated AVRO-383:
-------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed revision 904596.
I tried to refactor the code with a generic schema walker so that both
GenericDatumReader and ResolvingGrammarGenerator can use. But it became much
more complex than what we have today. So I settled for the logic and code
duplication.
Thanks Doug and Philip for your review and comments.
bq. > There is a proposal to implement GenericDatumReader using
ResolvingDecoder.
bq. Do we yet have a Jira for this?
I'm still working on benchmark to demonstrate the benefits. I file a JIRA
possibly tomorrow.
> Optiminzing ResolvingDecoder for default values
> -----------------------------------------------
>
> Key: AVRO-383
> URL: https://issues.apache.org/jira/browse/AVRO-383
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Attachments: AVRO-383-test.patch, AVRO-383.patch
>
>
> When the reader's and writer's schemas are records and the reader's schema
> has a field with default value and the writer's schema doesn't have the
> field, the ResolvingDecoder keeps the default value in a byte array. This
> byte array is in Json format. Moving this to Avro binary format improves
> performance.
> Apply the test patch and try "Perf -M". Then apply the patch and run it
> again. On my machine, the performance is three times the original.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
