[ 
https://issues.apache.org/jira/browse/AVRO-383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thiruvalluvan M. G. reopened AVRO-383:
--------------------------------------


The patch is incomplete:
    - The skip operation still uses the JSonDecoder. Probably, this problem 
will never be caught because the default values will never be skipped - the 
default value come into play when the reader wants it and the writer doesn't 
have it. Skip happens when the situation is the other way around - writer has 
it and reader doesn't want it. Nevertheless, the API allows skip of default 
values, we should fix it.
   - With the Json decoder gone, DefaultStartAction no longer needs the the 
field "root".

The new patch fixes both the problems. 

> Optiminzing ResolvingDecoder for default values
> -----------------------------------------------
>
>                 Key: AVRO-383
>                 URL: https://issues.apache.org/jira/browse/AVRO-383
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Thiruvalluvan M. G.
>            Assignee: Thiruvalluvan M. G.
>         Attachments: AVRO-383-test.patch, AVRO-383.patch
>
>
> When the reader's and writer's schemas are records and the reader's schema 
> has a field with default value and the writer's schema doesn't have the 
> field, the ResolvingDecoder keeps the default value in a byte array. This 
> byte array is in Json format. Moving this to Avro binary format improves 
> performance.
> Apply the test patch and try "Perf -M". Then apply the patch and run it 
> again. On my machine, the performance is three times the original.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to