At 1231616558 time_t, Maxime COSTE wrote: > here is an enhanced patch, adaptile now does not leave gaps between columns of > terminals.
Your implementation is very nice, and I think you are going into the
right direction. I even think we could replace the old tile layout,
which is not as much optimized as yours.
I'm not against merging this patch as it is, but I'd like to add some
ideas, remarks I have before you continue working on this:
- Implements mouse support; should be trivial, should be like tile.
- Implements equivalent to tileup/bottom/left; not a big deal I guess.
- Add more documentation.
The current tile (not yours) is totally unreadable and
no-understandable. I'd be more than happy if your implementation was
better documented than the current default one, so we can easily
reread and find potential problem or improve it.
I guess you wrote that one just as a proof of concept; to me the
concept seems rather good so, please, enhance, document and explain
your implementation. ;-)
- Use size hints directly.
You iterate until 3 times to find the good width/height. That's nice,
but that's an overkill approach since all size hints are available
in Lua.
If you don't know how to use size hints, take a look at:
- ICCCM spec for the paper doc
- client.c for the code using the size hints. It's really trivial and
that should be almost self-explanatory.
I hope I did not get something wrong reading your code since I did
pretty quickly to give you a first feedback.
Thank you very much for your work.
Cheers,
--
Julien Danjou
// ᐰ <[email protected]> http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
signature.asc
Description: Digital signature
