Properties masterwindows and otherwindows are what keep track of the weights of 
the windows. Basically this is where I store everything. I kepp them separate 
so in case you do something to the master windows (when you have more than one) 
then they are saved separate from the slave windows. 

The reason that this implementation doesn't suffer from the same things you 
mention is that I keep the calues normalized. 


-----Original Message-----
From: Julien Danjou <[email protected]>

Date: Wed, 14 Jan 2009 11:56:32 
To: <[email protected]>
Subject: Re: VILE Layout (Variable-Size Tile)


Hi Donald,

At 1231887077 time_t, Donald Ephraim Curtis wrote:
> I basically rewrite the tile layout by changing how the dimension
> calculations were handled.  It's a little more CPU intense.  Basically,
> each window is given a proportion.  If one window had a 1.5 and the
> other has a 1, then these are averaged out and one window will take up
> 75% and the other will date up 25%.  The proportions are normalized to
> 1 except in the case where you initially add a window.  
> 
> It definitely needs some tweaking but it's good enough to let me be in
> awesome again.

Thank you very much for your work.

Marco already tried to implement such a thing but we encountered various
problem. Dig into the archive to find the thread. :)
Basically, the thing is that using a 'weight' attribute like you are
doing can end up with huge value, just to have 50%-50% with 2 windows.

But well since that discussion a year ago came up with nothing better as
implementation I think I'd be rather enclined to merge such a patch
right now.

On another side, I did not get the usefulness of properties masterwindow
and otherwindow.

> PS: There are actually two patches, I forgot some stuff on my initial
> commit and well, now there are two.

You can squash them in one using git rebase --interactive easily.

Cheers,
-- 
Julien Danjou
// ᐰ <[email protected]>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD

Reply via email to