Thanks Donald,
I can happily test your patch, hopefully later I'll go through the
code and patch it myself or send you my comments
Ok first some formatting issues (which I think Julien takes seriously)
0001-vile-is-a-Variable-tILE-layout-that-allows-the-user(2).patch:51:
trailing whitespace.
-- Set the window by index (or the currently selected window)
0001-vile-is-a-Variable-tILE-layout-that-allows-the-user(2).patch:423:
trailing whitespace.
or lay == layout.suit.vile.bottom
warning: 2 lines add whitespace errors.
So two lines have trailing whitespace.
Ok, so first I am testing with the default rc.lua, just patched to
used vile instead of tile.down.
My first tests are using xterm (pretty standard app I believe).
So If I open 1,2,3,etc.. clients in an empty tag vile works as
expected. However vertical resize with the mouse still does not work
(I am not aware on how to perform vertical resize with the keyboard
btw), and without this VILE seems not to provide anything that TILE
cannot do.
Also with programs != xterm the story is not so successful For
example, I use sakura instead of xterm and almost nothing works as
expected when opening several instances of sakura (or when closing
them), I invite you to download sakura and test it with VILE, sakura
works perfectly with TILE btw.
Cheers,
Alex
On Thu, Jan 15, 2009 at 7:56 PM, Donald Ephraim Curtis
<[email protected]> wrote:
> Guys,
>
> Made a new fix. I was able to get mouse resizing working (both
> horizontal and verticle) and it seems to work pretty well. I could
> really use someone to kinda go over the code and think of some
> optimizations. I know for a fact that in my layout code itself there
> are some assignments that are probably redundant and could be fixed but
> I haven't had the time to sit down and fix them. Please let me know of
> anymore bugs.
>
> Oh, I also fixed it so if there is only one window it will take up the
> whole work area.
>
> I merged all my commits into one patch on top of the newest master
> (thanks git) so I am not officially seeing why git is so beautiful.
>
> --
> Donald
>
> (Thu, Jan 15, 2009 at 02:05:02PM -0500) Alex Cornejo <[email protected]>:
>> Just tested.
>>
>> I'm not sure how it is supposed to work, I was not able to resize
>> vertically using the mouse, and actually not even horizontal resize
>> worked with the mouse (but it did with the keyb).
>>
>> Also, the layout icon for vile is missing and should be added. And in
>> tags with a single window vile failed to use the whole workspace (it
>> just displayed on the window on half the screen).
>>
>> Cheers,
>>
>> Alex
>>
>>
>> On Wed, Jan 14, 2009 at 10:45 AM, Julien Danjou <[email protected]> wrote:
>> > At 1231945407 time_t, Donald Ephraim Curtis wrote:
>> >> Properties masterwindows and otherwindows are what keep track of the
>> >> weights of the windows. Basically this is where I store everything. I
>> >> kepp them separate so in case you do something to the master windows
>> >> (when you have more than one) then they are saved separate from the slave
>> >> windows.
>> >>
>> >> The reason that this implementation doesn't suffer from the same things
>> >> you mention is that I keep the calues normalized.
>> >
>> > Thanks for the explanation.
>> >
>> > It'd be nice to have usage feedbacks from people from this list.
>> >
>> > Anyone?
>> >
>> > --
>> > Julien Danjou
>> > // ᐰ <[email protected]> http://julien.danjou.info
>> > // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
>> >
>> > -----BEGIN PGP SIGNATURE-----
>> > Version: GnuPG v1.4.9 (GNU/Linux)
>> >
>> > iEYEARECAAYFAkluCJsACgkQpGK1HsL+5c33CgCfX+cP7VjH5n45Yf0i1oBeWtEO
>> > +yYAn2dfHEP8kGE9kHKQ3C/OsYgHBH5c
>> > =OCPv
>> > -----END PGP SIGNATURE-----
>> >
>> >
>
