Hi Donald, I've take some time to review your patch finally.
At 1232587540 time_t, Donald Ephraim Curtis wrote:
> +local function normalize(set, max)
> + total = 0
Please declare your variable as local. :)
> +-- Calculate which {index, column} the client belongs to given the index
If the function is meant to be exported, proper luadoc formatted
documentation is very welcome.
But well I'm not sure we want to export this one.
> +function idx(c)
> + local c = c or capi.client.focus
It misses:
if not c then return end
which would avoid errors for people pressing a wrong key. ;)
> +-- Set the window by index (or the currently selected window)
luadoc also, otherwise people won't heard of it.
> +function setwfact(wfact, c)
> + -- get the currently selected window
> + local c = c or capi.client.focus
if not c then return end
:)
> +-- Change the width factor of a window (indexed by number)
luadoc ;)
Cheers,
--
Julien Danjou
// ᐰ <[email protected]> http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD
signature.asc
Description: Digital signature
