On Sun, May 17, 2009 at 17:34, JLM <[email protected]> wrote:
> I attempted to prevent gkrellm from floating by modifying floatapps like
> this:
>
> ["gkrellm"] = false,

This has no chance of working, even provided right class/instance is
specified, because the floatapps code here:
  if floatapps[cls] then awful.client.floating.set(c, floatapps[cls]) ...
will evaluate the condition as false and therefore won't call the
awful function.

I've seen a lot of people struggling to get this or that to unfloat
and I think it's high time to make it possible with the default rc's
floatapps. The patch is trivial:

  -    if floatapps[cls] then
  +    if floatapps[cls] ~= nil then

Attached a patch on top of master so that new users can enjoy this
starting with 3.3.

thanks
koniu

ps. Just for the record: as clarified with JLM on #awesome setting
c.floating doesn't do anything.

The wiki needs some serious work guys as parts of it are terribly out of date:
http://awesome.naquadah.org/wiki/index.php?title=Awesome_3_configuration
From 11ec538f42999f8493160f251bf5331a3a01d797 Mon Sep 17 00:00:00 2001
From: koniu <[email protected]>
Date: Sun, 17 May 2009 20:05:10 +0100
Subject: [PATCH] awesomerc: allow 'false' in floatapps

Signed-off-by: koniu <[email protected]>
---
 awesomerc.lua.in |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/awesomerc.lua.in b/awesomerc.lua.in
index 40e97d5..99df879 100644
--- a/awesomerc.lua.in
+++ b/awesomerc.lua.in
@@ -375,9 +375,9 @@ awful.hooks.manage.register(function (c, startup)
     -- Check if the application should be floating.
     local cls = c.class
     local inst = c.instance
-    if floatapps[cls] then
+    if floatapps[cls] ~= nil then
         awful.client.floating.set(c, floatapps[cls])
-    elseif floatapps[inst] then
+    elseif floatapps[inst] ~= nil then
         awful.client.floating.set(c, floatapps[inst])
     end
 
-- 
1.6.3.1

Reply via email to