At 1244310805 time_t, Uli Schlachter wrote: > You would also have saved quite a few LOCs if you implemented the new > progressbar and graphs in C. You would have saved even more LOCs if you just > removed all the widgets.... I mean, it's all about code size, isn't it? (dwm, > anyone?)
No, it's about code maintainability. 200 SLOC of Lua beats - by large - more than 1 K SLOC of C. :-) Between drawing cairo graph drawing routine and Imlib2, we've almost doublon of code. > In response to that other mail (too lazy to write two mails): "What is scale"? > I have a graph which shows how much network bandwidth I use. The graph C code > used to automatically make sure that the graph fills the whole graph widget > (it > used the biggest shown value as "max_value" if "scale" was enabled). Therefor, > if we add back this really nice feature, adding back "max_value" would be a > small patch since the "scale" code needs most of this anyway... Ok, well scale seems that it can be useful, since it's a drawing feature. max_value is not something that should be added, graph is about data drawing, not data management. > Oh and here are some screenshots: > Before (I think this is 3.2.1 or sth like that): > http://tinyurl.com/lnssm2 > > Current master: > http://people.znc.in/~psychon/files/stuff/awesome-broke.png > (This is after I fixed most of the things that I can fix with the current > code. > I guess I could also fix the colors for the progressbars, but if they stay > like > this I'll remove them anyway and look for a new WM....) Not sure I understand what you mean. Lua progressbar color can be changed and rendered vertically. I admit there's no tick support for now. And, as I can see with your first screenshot, simple graph like that should be feasible easily with Lua graph widget. Still cheers, -- Julien Danjou // ᐰ <jul...@danjou.info> http://julien.danjou.info // 9A0D 5FD9 EB42 22F6 8974 C95C A462 B51E C2FE E5CD // In the Sixth Sense, Bruce Willis is dead.
signature.asc
Description: Digital signature
