On Fri, May 21 2010, Daniel Graña wrote: > This is my first attempt to ideal patch, please review it at > http://gist.github.com/408472
1. You should fix the indentation to respect the one used in awesome; 2. In systray_init(): screen.systray.registered = false; is useless (it's false by default); 3. You should not do: screen.systray.registered = true; in wibox_systray_refresh(), but rather in systray_register(). This is just my opinion, feel free to correct me if you think I'm wrong. The patch would need some volunteer to test it, but it seems ok and mergeable to me. Do you plan to make an extra patch to unregister the systray when the widget disappear ? -- Julien Danjou // ᐰ <[email protected]> http://julien.danjou.info
pgpWqPr3MA2DI.pgp
Description: PGP signature
