On Sat, May 22, 2010 at 4:43 AM, Uli Schlachter <[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Am 21.05.2010 21:27, Daniel Graña wrote: > > Here is another patch that unregister systray if no systray widget is > found > > for a wibox. > > see http://gist.github.com/409310 > > > > screen_t screen = globalconf.screens.tab[phys_screen]; > > Uhm, won't that *copy* the screen_t? That's slow and that also means that > all > changes made to it will have no effect. > that's true, I updated the patch and reverted the modification to wibox.c related to screen_t http://gist.github.com/412326 > Also, didn't you mean to move "screen.systray.registered = true;" into systray_register()? (I would also move the check of 'if(!screen.systray.registered = true)' into systray_register()) Done, wibox.c is much clear now. > Also, is systray_init() still needed? I think creating the window can be moved into systray_register() If the systray is never registered then the window will be never created, and the variable will be unitiliazed. You complained about this in my first patch, in that patch I didn't called systray_init at all when user pass --nosystray command line option. Thanks, Daniel > > - -- > - - Buck, when, exactly, did you lose your mind? > - - Three months ago. I woke up one morning married to a pineapple. > An ugly pineapple... But I loved her! > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.10 (GNU/Linux) > > iQEcBAEBCAAGBQJL94seAAoJECLkKOvLj8sGHskIAM27UoNZKOC94R8vC81IH80C > JGGpdLvfu6qvo0OVDM0u5VOz66YDMDzNrcVg/tEzDktqDI45gMAER6yzwiPT6hsP > Dy5KwZOCfbmhEdlyrVMPI+j9z0Gnl6iT8WI/ZqhqmUmpwdCWFyuiIj+375/H7gSe > k7zDLs7N3ufUr/ECw6aRIPwVTRzci0GdqwIJVrblCrHIZRKbxXCr59UXvtHFRixS > I3u5g4LYcpBWKrD27iaRkPN694jX4YkQfGH60RgxwogNFWe1afZ6Jo+b0K+VcdSX > vVnvP2b8LUsqZd3q5QZpegQDwZz6QKJerRxXRo/m55ksyoiPwUpdDkwI0ZyGvlk= > =/GAE > -----END PGP SIGNATURE----- >
