On 05.01.2012 17:15, Anurag Priyam wrote: > Started using awesome from git master few hours back. Couldn't help > notice the sweet, client property hints (for ontop, floating and > stuff) in the tasklist :). Attached are two minor improvements that I > think will make it even better.
Hi, thanks for those patches, but... > From 9f564a4b7e81346cabcb01e91042948ace1251c5 Mon Sep 17 00:00:00 2001 > From: Anurag Priyam <[email protected]> > Date: Thu, 5 Jan 2012 19:03:42 +0530 > Subject: [PATCH 1/2] tasklist: visually separate client-property-hints (for > floating, ontop, etc.) > > Basically, we enclose the corresponding characters within square brackets. So > '^' (for ontop) becomes '[^] '. Such visual distinction is particularly > helpful, for example, when using 'floating' and 'ontop' together. ... I'm not sure if I like this. However, it shouldn't matter too much what I like. Instead, this should be made configurable, somehow. What would you think about sending in a patch instead which adds a new line to the long lists of options at the beginning of tasklist_label? local str_float = args.tasklist_floating or theme.tasklist_floating or "✈" > Subject: [PATCH 2/2] > =?UTF-8?q?tasklist:=20introduce=20client-property-hint=20?= > =?UTF-8?q?for=20'sticky':=20'[=E2=96=AA]'?= Woah, wtf? Encodings are evil and ugly. > So a "[▪]" before the client name in the tasklist implies it is sticky. I'm not sure if I'd associate that icon with "sticky" immediately. Someone on IRC will ask "there is a black square in my tasklist, why?" ;-) However, since I don't have any better ideas for an icon and I like the idea of adding one for sticky, I'll push this if no one comes up with a better icon. Could you change the first patch, turn [▪] into ▪ in the second patch and re-send? Thanks, Uli -- 'dubito ergo sum' -- Elke's whiteboard -- To unsubscribe, send mail to [email protected].
