On Thu, Jan 5, 2012 at 10:46 PM, Uli Schlachter <[email protected]> wrote: >> Subject: [PATCH 1/2] tasklist: visually separate client-property-hints (for >> floating, ontop, etc.) >> >> Basically, we enclose the corresponding characters within square brackets. [...] > Instead, this should be made > configurable, somehow.
Cool. I thought that would be too much for such a simple thing. But then, it was the first thing I set out to change after the move :P. And personal preferences are, well, personal preferences. [...] > local str_float = args.tasklist_floating or theme.tasklist_floating or "✈" I would have preferred theme only. But considering how other options are dealt with, args + theme + default seems to be the way to go. >> Subject: [PATCH 2/2] >> =?UTF-8?q?tasklist:=20introduce=20client-property-hint=20?= >> =?UTF-8?q?for=20'sticky':=20'[=E2=96=AA]'?= > > Woah, wtf? Encodings are evil and ugly. Ooops. >> So a "[▪]" before the client name in the tasklist implies it is sticky. > > I'm not sure if I'd associate that icon with "sticky" immediately. Someone on > IRC will ask "there is a black square in my tasklist, why?" ;-) [...] I thought of it like 'pinning' a client. Like sticky notes with thumb tacks in one corner. So I used a bullet first, but it was hardly noticeable. Hence the square. Do you think a bullet would be better? > Could you change the first patch, turn [▪] into ▪ in the second patch and > re-send? In a while. Thanks for the review :). -- Anurag Priyam -- To unsubscribe, send mail to [email protected].
