Since the initial patch got accepted, I worked the other occurrences as well. Felix
From 726ccc115124e702b7efe3a44894fc45f84d868a Mon Sep 17 00:00:00 2001 From: Felix Bier <[email protected]> Date: Sun, 13 May 2012 00:23:05 +0200 Subject: [PATCH 1/3] Return condition value instead of conditional true/false
Signed-off-by: Felix Bier <[email protected]> --- lib/awful/key.lua.in | 5 +---- 1 Datei geändert, 1 Zeile hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/lib/awful/key.lua.in b/lib/awful/key.lua.in index b88cd29..10aa9ee 100644 --- a/lib/awful/key.lua.in +++ b/lib/awful/key.lua.in @@ -67,10 +67,7 @@ function match(key, pressed_mod, pressed_key) end -- If the number of pressed modifier is ~=, it is probably >, so this is not -- the same, return false. - if #pressed_mod ~= #mod then - return false - end - return true + return #pressed_mod == #mod end setmetatable(_M, { __call = function(_, ...) return new(...) end }) -- 1.7.10.2
From 4ab70e8f4f9042e526c329dde24e4d35c767eb9e Mon Sep 17 00:00:00 2001 From: Felix Bier <[email protected]> Date: Sun, 13 May 2012 00:23:23 +0200 Subject: [PATCH 2/3] Return condition value instead of conditional true/false Signed-off-by: Felix Bier <[email protected]> --- lib/wibox/widget/base.lua.in | 8 +------- 1 Datei geändert, 1 Zeile hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/lib/wibox/widget/base.lua.in b/lib/wibox/widget/base.lua.in index 1d17d16..9ee6bb7 100644 --- a/lib/wibox/widget/base.lua.in +++ b/lib/wibox/widget/base.lua.in @@ -24,13 +24,7 @@ end --- Handle a button event on a widget. This is used internally. function handle_button(event, widget, x, y, button, modifiers) local function is_any(mod) - if #mod ~= 1 then - return false - end - if mod[1] ~= "Any" then - return false - end - return true + return #mod == 1 and mod[1] == "Any" end local function tables_equal(a, b) -- 1.7.10.2
From 3d4b4dfa491bcf7a3bb326349f642736489fc6a1 Mon Sep 17 00:00:00 2001 From: Felix Bier <[email protected]> Date: Sun, 13 May 2012 00:23:35 +0200 Subject: [PATCH 3/3] Return condition value instead of conditional true/false Signed-off-by: Felix Bier <[email protected]> --- lib/awful/widget/taglist.lua.in | 6 +----- 1 Datei geändert, 1 Zeile hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/lib/awful/widget/taglist.lua.in b/lib/awful/widget/taglist.lua.in index 05256bf..a6ec7f6 100644 --- a/lib/awful/widget/taglist.lua.in +++ b/lib/awful/widget/taglist.lua.in @@ -172,11 +172,7 @@ end -- @param screen The screen we are drawing on. -- @return true if t is not empty, else false function filter.noempty(t, args) - if #t:clients() > 0 or t.selected then - return true - end - - return false + return #t:clients() > 0 or t.selected end --- Filtering function to include all tags on the screen. -- 1.7.10.2
signature.asc
Description: This is a digitally signed message part
