... and attachments :(
On Sat, 11 Jan 2014 23:09:26 +0100 lukash <lukk...@email.cz> wrote:
> Ok,
>
> after trying out John's rc, I definitely see there is a problem. This
> problem does not manifest in my rc, because it actually doesn't
> alternatively nest horizontal vs. vertical layouts without including a
> fixed one every other nesting level to set some constraints.
>
> John's patches only break my rc (in a rather minor way) by having
> _expand default to 'inside' which stretches the middle widget to the
> available space.
>
> But this is where the problem is. If nesting alternatively horizontal
> and vertical layouts, on the third level it may happen that a widget
> will take all space in its primary dimension (the 'in direction'
> dimension, eg. x for horizontal flex) and its parent will just pass it
> through in its secondary dimension (its the same dimension, but the
> parent has perpendicular direction). Then on the first level you
> suddenly have all the space taken by that widget.
>
> Since I probably didn't do a good job explaining it, lets use John's rc
> as an example. He has some third-party modules in it so I'm attaching a
> quickly hacked version that should work without sorting out includes.
>
> John has a main horizontal align layout, which has vertical flex on
> left and right. So far so good, but inside the right one he has another
> horizontal align layout. Which at the time of drawing will take up all
> horizontal space available, leaving nothing for the middle widget (a
> tasklist) in the main horizontal layout. (Because widgets in align are
> drawn in order first -> third -> second.)
>
> John's solution of this problem seems to be valid - change the fit
> function of these two layouts (or, it should be any layout that would
> eat all the space in current code) to take up only minimum necessary
> space it requires. Then, when it is drawn, it will still draw to all
> the available space.
>
> However, consider attached patch rc_patch.diff to John's rc. Run it
> and open a lot of clients. The tasklist will push the clock out.
> Therefore it actually might be better if the fit function for flex
> layout returned 0 and/or give it an optional min_size attribute. In
> fact, I've just found out this also happens with default config if you
> set its expand from 'inside' to 'none' (if you open a lot of clients
> they will push out the widgets on the sides).
>
> Regarding the new expand modes in align layout, why has the middle
> widget take up all the space in patch 0001? This broke my rc as
> mentioned above and so far I was unable to find a way to fix it,
> nesting 'none' and 'inside' align layouts didn't work... I haven't
> found what the problem is yet. And I'm not sure why the set_expand()
> was actually needed, when you changed it so that middle widget takes
> all the space? This solution feels weird to me.
>
> While messing around, I've also noticed that the 'none' expand mode
> acted really weird on my tasklist (it seemed to limit it to
> approximately half the available size or something). I didn't
> investigate it yet. I'm not sure I'll have much more time to fiddle
> with it... :(
>
> cheers
> Lukas
>
> --
> To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
--- a/rc.lua
+++ b/rc.lua
@@ -239,8 +239,7 @@ for s = 1, screen.count() do
-- Now bring it all together (with the tasklist in the middle)
local layout = wibox.layout.align.horizontal()
- layout:set_left(left_layout)
- layout:set_middle(mytasklist[s])
+ layout:set_left(mytasklist[s])
layout:set_right(right_layout)
mywibox[s]:set_widget(layout)
-- Standard awesome library
local gears = require("gears")
local awful = require("awful")
awful.rules = require("awful.rules")
require("awful.autofocus")
-- Widget and layout library
local wibox = require("wibox")
-- Theme handling library
local beautiful = require("beautiful")
-- Notification library
local naughty = require("naughty")
local menubar = require("menubar")
--local freedesktop_utils = require("config.awesome-freedesktop.freedesktop.utils")
--local freedesktop_menu = require("config.awesome-freedesktop.freedesktop.menu")
-- {{{ Error handling
-- Check if awesome encountered an error during startup and fell back to
-- another config (This code will only ever execute for the fallback config)
if awesome.startup_errors then
naughty.notify({ preset = naughty.config.presets.critical,
title = "Oops, there were errors during startup!",
text = awesome.startup_errors })
end
-- Handle runtime errors after startup
do
local in_error = false
awesome.connect_signal("debug::error", function (err)
-- Make sure we don't go into an endless error loop
if in_error then return end
in_error = true
naughty.notify({ preset = naughty.config.presets.critical,
title = "Oops, an error happened!",
text = err })
in_error = false
end)
end
-- }}}
-- {{{ Variable definitions
-- Themes define colours, icons, and wallpapers
beautiful.init("/usr/share/awesome/themes/zenburn/theme.lua")
-- This converts hex colors from #RRBBGG to "rgb:RR/BB/GG"
function hextoxterm(hex)
return "\"rgb:" .. string.sub(hex,2,3) .. "/" .. string.sub(hex,4,5) .. "/" .. string.sub(hex,6,7).. "\""
end
-- This is used later as the default terminal and editor to run.
terminal = "xterm -bg " .. hextoxterm( beautiful.bg_normal ) ..
" -fg " .. hextoxterm( beautiful.fg_normal ) ..
" -selbg " .. hextoxterm( beautiful.bg_focus ) ..
" -selfg " .. hextoxterm( beautiful.fg_focus )
editor = os.getenv("EDITOR") or "nano"
editor_cmd = terminal .. " -e " .. editor
-- Default modkey.
-- Usually, Mod4 is the key with a logo between Control and Alt.
-- If you do not like this or do not have such a key,
-- I suggest you to remap Mod4 to another key using xmodmap or other tools.
-- However, you can use another modifier like Mod1, but it may interact with others.
modkey = "Mod4"
-- Table of layouts to cover with awful.layout.inc, order matters.
local layouts =
{
awful.layout.suit.floating,
awful.layout.suit.tile,
awful.layout.suit.tile.left,
awful.layout.suit.tile.bottom,
awful.layout.suit.tile.top,
awful.layout.suit.fair,
awful.layout.suit.fair.horizontal,
awful.layout.suit.spiral,
-- awful.layout.suit.spiral.dwindle,
awful.layout.suit.max,
-- awful.layout.suit.max.fullscreen,
-- awful.layout.suit.magnifier
}
-- }}}
-- {{{ Wallpaper
if beautiful.wallpaper then
for s = 1, screen.count() do
gears.wallpaper.maximized(beautiful.wallpaper, s, true)
end
end
-- }}}
-- {{{ Tags
-- Define a tag table which hold all screen tags.
tags = {}
for s = 1, screen.count() do
-- Each screen has its own tag table.
tags[s] = awful.tag({ 1, 2, 3, 4, 5, 6, 7, 8, 9 }, s, layouts[1])
end
-- }}}
-- {{{ Menu
-- Create a laucher widget and a main menu
--freedesktop.utils.terminal = terminal
--freedesktop.utils.icon_theme = 'gnome'
--
--menu_items = freedesktop.menu.new()
--
--myawesomemenu = {
-- { "manual", terminal .. " -e man awesome", freedesktop.utils.lookup_icon({ icon = 'help' }) },
-- { "edit config", editor_cmd .. " " .. awesome.conffile, freedesktop.utils.lookup_icon({ icon = 'package_settings' }) },
-- { "restart", awesome.restart, freedesktop.utils.lookup_icon({ icon = 'gtk-refresh' }) },
-- { "quit", awesome.quit,freedesktop.utils.lookup_icon({ icon = 'gtk-quit' }) }
--}
--
--table.insert(menu_items, { "awesome", myawesomemenu, beautiful.awesome_icon })
--table.insert(menu_items, { "terminal", terminal, freedesktop.utils.lookup_icon({icon = 'terminal'}) })
mymainmenu = awful.menu({ items = {}})
mylauncher = awful.widget.launcher({ image = beautiful.awesome_icon,
menu = mymainmenu })
-- Menubar configuration
menubar.utils.terminal = terminal -- Set the terminal for applications that require it
-- }}}
-- {{{ Wibox
-- Create a textclock widget
mytextclock = awful.widget.textclock()
-- Create a wibox for each screen and add it
mywibox = {}
mypromptbox = {}
mylayoutbox = {}
mytaglist = {}
mytaglist.buttons = awful.util.table.join(
awful.button({ }, 1, awful.tag.viewonly),
awful.button({ modkey }, 1, awful.client.movetotag),
awful.button({ }, 3, awful.tag.viewtoggle),
awful.button({ modkey }, 3, awful.client.toggletag),
awful.button({ }, 4, function(t) awful.tag.viewnext(awful.tag.getscreen(t)) end),
awful.button({ }, 5, function(t) awful.tag.viewprev(awful.tag.getscreen(t)) end)
)
mytasklist = {}
mytasklist.buttons = awful.util.table.join(
awful.button({ }, 1, function (c)
if c == client.focus then
c.minimized = true
else
-- Without this, the following
-- :isvisible() makes no sense
c.minimized = false
if not c:isvisible() then
awful.tag.viewonly(c:tags()[1])
end
-- This will also un-minimize
-- the client, if needed
client.focus = c
c:raise()
end
end),
awful.button({ }, 3, function ()
if instance then
instance:hide()
instance = nil
else
instance = awful.menu.clients({ width=250 })
end
end),
awful.button({ }, 4, function ()
awful.client.focus.byidx(1)
if client.focus then client.focus:raise() end
end),
awful.button({ }, 5, function ()
awful.client.focus.byidx(-1)
if client.focus then client.focus:raise() end
end))
for s = 1, screen.count() do
-- Create a promptbox for each screen
mypromptbox[s] = awful.widget.prompt()
-- Create an imagebox widget which will contains an icon indicating which layout we're using.
-- We need one layoutbox per screen.
mylayoutbox[s] = awful.widget.layoutbox(s)
mylayoutbox[s]:buttons(awful.util.table.join(
awful.button({ }, 1, function () awful.layout.inc(layouts, 1) end),
awful.button({ }, 3, function () awful.layout.inc(layouts, -1) end),
awful.button({ }, 4, function () awful.layout.inc(layouts, 1) end),
awful.button({ }, 5, function () awful.layout.inc(layouts, -1) end)))
-- Create a taglist widget
mytaglist[s] = awful.widget.taglist(s, awful.widget.taglist.filter.all, mytaglist.buttons)
-- Create a tasklist widget
mytasklist[s] = awful.widget.tasklist(s, awful.widget.tasklist.filter.currenttags, mytasklist.buttons)
-- Create the wibox
mywibox[s] = awful.wibox({ position = "top", screen = s, height = 36 })
-- Widgets that are aligned to the left
local left_layout_top = wibox.layout.fixed.horizontal()
left_layout_top:add(mytaglist[s])
local left_layout_bottom = wibox.layout.fixed.horizontal()
left_layout_bottom:add(mylauncher)
left_layout_bottom:add(mypromptbox[s])
local left_layout = wibox.layout.flex.vertical()
left_layout:add(left_layout_top)
left_layout:add(left_layout_bottom)
-- Widgets that are aligned to the right
local right_layout_top = wibox.layout.align.horizontal()
if s == 1 then right_layout_top:set_left(wibox.widget.systray()) end
right_layout_top:set_right(mylayoutbox[s])
local right_layout_bottom = wibox.layout.fixed.horizontal()
right_layout_bottom:add(mytextclock)
-- local right_layout_top_container = wibox.layout.fixed.horizontal()
-- right_layout_top_container:add( right_layout_top )
-- debug = "width:" .. right_layout_bottom.width
local right_layout_top_container = wibox.layout.constraint()
right_layout_top_container:set_widget( right_layout_top )
right_layout_top_container:set_width( 150 )
right_layout_top_container:set_strategy( 'max' )
-- local right_layout_top_container = wibox.layout.mirror()
-- right_layout_top_container:set_widget( right_layout_top )
-- right_layout_top_container:set_reflection({horizontal=true, vertical=false})
local right_layout = wibox.layout.flex.vertical()
right_layout:add(right_layout_top)
right_layout:add(right_layout_bottom)
-- Now bring it all together (with the tasklist in the middle)
local layout = wibox.layout.align.horizontal()
layout:set_left(left_layout)
layout:set_middle(mytasklist[s])
layout:set_right(right_layout)
mywibox[s]:set_widget(layout)
end
-- }}}
-- {{{ Mouse bindings
root.buttons(awful.util.table.join(
awful.button({ }, 3, function () mymainmenu:toggle() end),
awful.button({ }, 4, awful.tag.viewnext),
awful.button({ }, 5, awful.tag.viewprev)
))
-- }}}
-- {{{ Key bindings
globalkeys = awful.util.table.join(
-- Navigation
awful.key({ modkey, }, "Left", awful.tag.viewprev, "Previous Tag" ),
awful.key({ modkey, }, "Right", awful.tag.viewnext, "Next Tag" ),
awful.key({ modkey, }, "Escape", awful.tag.history.restore, "Go Back"),
awful.key({ modkey, }, "j",
function ()
awful.client.focus.byidx( 1)
if client.focus then client.focus:raise() end
end, "Next Client"),
awful.key({ modkey, }, "k",
function ()
awful.client.focus.byidx(-1)
if client.focus then client.focus:raise() end
end, "Previous Client"),
-- Layout manipulation
awful.key({ modkey, "Shift" }, "j", function () awful.client.swap.byidx( 1) end,
"Swap with next client"),
awful.key({ modkey, "Shift" }, "k", function () awful.client.swap.byidx( -1) end,
"Swap with previous client"),
awful.key({ modkey, "Control" }, "j", function () awful.screen.focus_relative( 1) end),
awful.key({ modkey, "Control" }, "k", function () awful.screen.focus_relative(-1) end),
awful.key({ modkey, }, "u", awful.client.urgent.jumpto),
awful.key({ modkey, }, "Tab",
function ()
awful.client.focus.history.previous()
if client.focus then
client.focus:raise()
end
end),
awful.key({ modkey, }, "l", function () awful.tag.incmwfact( 0.05) end,
"Increase master size 5%" ),
awful.key({ modkey, }, "h", function () awful.tag.incmwfact(-0.05) end,
"Decrease master size 5%" ),
awful.key({ modkey, "Shift" }, "h", function () awful.tag.incnmaster( 1) end,
"Add a client to the master column" ),
awful.key({ modkey, "Shift" }, "l", function () awful.tag.incnmaster(-1) end,
"Subtract a client from the master column" ),
awful.key({ modkey, "Control" }, "h", function () awful.tag.incncol( 1) end,
"Add a column" ),
awful.key({ modkey, "Control" }, "l", function () awful.tag.incncol(-1) end,
"Subtract a column" ),
awful.key({ modkey, }, "space", function () awful.layout.inc(layouts, 1) end,
"Next Layout" ),
awful.key({ modkey, "Shift" }, "space", function () awful.layout.inc(layouts, -1) end,
"Previous Layout" ),
-- Standard program
awful.key({ modkey, }, "Return", function () awful.util.spawn(terminal) end,
"Terminal" ),
awful.key({ modkey, "Control" }, "r", awesome.restart, "Restart"),
awful.key({ modkey, "Shift" }, "q", awesome.quit, "Quit"),
awful.key({ modkey, "Control" }, "n", awful.client.restore),
-- Prompt
awful.key({ modkey }, "r", function () mypromptbox[mouse.screen]:run() end,
"Command Prompt"),
awful.key({ modkey, "Shift" }, "r",
function ()
awful.prompt.run({ prompt = "Run Lua code: " },
mypromptbox[mouse.screen].widget,
awful.util.eval, nil,
awful.util.getdir("cache") .. "/history_eval")
end, "Lua Prompt"),
awful.key({ modkey, }, "w", function () mymainmenu:show({keygrabber=true}) end,
"Menu" ),
awful.key({ modkey, }, "p", function () menubar.show() end, "Menu Bar"),
awful.key({ modkey }, "F3", function() naughty.notify({text=debug, title="Debug"}) end, "Show the 'debug' variable")
)
clientkeys = awful.util.table.join(
awful.key({ modkey, }, "f", function (c) c.fullscreen = not c.fullscreen end),
awful.key({ modkey, }, "x", function (c) c:kill() end),
awful.key({ modkey, "Control" }, "space", awful.client.floating.toggle ),
awful.key({ modkey, "Control" }, "Return", function (c) c:swap(awful.client.getmaster()) end),
awful.key({ modkey, }, "o", awful.client.movetoscreen ),
awful.key({ modkey, }, "t", function (c) c.ontop = not c.ontop end),
awful.key({ modkey, }, "n",
function (c)
-- The client currently has the input focus, so it cannot be
-- minimized, since minimized clients can't have the focus.
c.minimized = true
end),
awful.key({ modkey, }, "m",
function (c)
c.maximized_horizontal = not c.maximized_horizontal
c.maximized_vertical = not c.maximized_vertical
end)
)
-- Bind all key numbers to tags.
-- Be careful: we use keycodes to make it works on any keyboard layout.
-- This should map on the top row of your keyboard, usually 1 to 9.
for i = 1, 9 do
globalkeys = awful.util.table.join(globalkeys,
awful.key({ modkey }, "#" .. i + 9,
function ()
local screen = mouse.screen
local tag = awful.tag.gettags(screen)[i]
if tag then
awful.tag.viewonly(tag)
end
end),
awful.key({ modkey, "Control" }, "#" .. i + 9,
function ()
local screen = mouse.screen
local tag = awful.tag.gettags(screen)[i]
if tag then
awful.tag.viewtoggle(tag)
end
end),
awful.key({ modkey, "Shift" }, "#" .. i + 9,
function ()
if client.focus then
local tag = awful.tag.gettags(client.focus.screen)[i]
if tag then
awful.client.movetotag(tag)
end
end
end),
awful.key({ modkey, "Control", "Shift" }, "#" .. i + 9,
function ()
if client.focus then
local tag = awful.tag.gettags(client.focus.screen)[i]
if tag then
awful.client.toggletag(tag)
end
end
end))
end
clientbuttons = awful.util.table.join(
awful.button({ }, 1, function (c) client.focus = c; c:raise() end),
awful.button({ modkey }, 1, awful.mouse.client.move),
awful.button({ modkey }, 3, awful.mouse.client.resize))
-- Set keys
root.keys(globalkeys)
-- }}}
-- {{{ Rules
awful.rules.rules = {
-- All clients will match this rule.
{ rule = { },
properties = { border_width = beautiful.border_width,
border_color = beautiful.border_normal,
focus = awful.client.focus.filter,
keys = clientkeys,
buttons = clientbuttons } },
{ rule = { class = "MPlayer" },
properties = { floating = true } },
{ rule = { class = "pinentry" },
properties = { floating = true } },
{ rule = { class = "Gimp" },
properties = { floating = true } },
-- Set Chromium to always map on tags number 2 and 3 of screen 1.
{ rule = { class = "Chromium-browser" },
properties = { tag = tags[1][2] } },
-- Set Pidgin to always map on tags number 1 of screen 1.
{ rule = { class = "Pidgin" },
properties = { tag = tags[1][1] } }
}
-- }}}
-- {{{ Signals
-- Signal function to execute when a new client appears.
client.connect_signal("manage", function (c, startup)
-- Enable sloppy focus
c:connect_signal("mouse::enter", function(c)
if awful.layout.get(c.screen) ~= awful.layout.suit.magnifier
and awful.client.focus.filter(c) then
client.focus = c
end
end)
if not startup then
-- Set the windows at the slave,
-- i.e. put it at the end of others instead of setting it master.
-- awful.client.setslave(c)
-- Put windows in a smart way, only if they does not set an initial position.
if not c.size_hints.user_position and not c.size_hints.program_position then
awful.placement.no_overlap(c)
awful.placement.no_offscreen(c)
end
end
local titlebars_enabled = false
if titlebars_enabled and (c.type == "normal" or c.type == "dialog") then
-- buttons for the titlebar
local buttons = awful.util.table.join(
awful.button({ }, 1, function()
client.focus = c
c:raise()
awful.mouse.client.move(c)
end),
awful.button({ }, 3, function()
client.focus = c
c:raise()
awful.mouse.client.resize(c)
end)
)
-- Widgets that are aligned to the left
local left_layout = wibox.layout.fixed.horizontal()
left_layout:add(awful.titlebar.widget.iconwidget(c))
left_layout:buttons(buttons)
-- Widgets that are aligned to the right
local right_layout = wibox.layout.fixed.horizontal()
right_layout:add(awful.titlebar.widget.floatingbutton(c))
right_layout:add(awful.titlebar.widget.maximizedbutton(c))
right_layout:add(awful.titlebar.widget.stickybutton(c))
right_layout:add(awful.titlebar.widget.ontopbutton(c))
right_layout:add(awful.titlebar.widget.closebutton(c))
-- The title goes in the middle
local middle_layout = wibox.layout.flex.horizontal()
local title = awful.titlebar.widget.titlewidget(c)
title:set_align("center")
middle_layout:add(title)
middle_layout:buttons(buttons)
-- Now bring it all together
local layout = wibox.layout.align.horizontal()
layout:set_left(left_layout)
layout:set_right(right_layout)
layout:set_middle(middle_layout)
awful.titlebar(c):set_widget(layout)
end
end)
client.connect_signal("focus", function(c) c.border_color = beautiful.border_focus end)
client.connect_signal("unfocus", function(c) c.border_color = beautiful.border_normal end)
-- }}}
