Hi guys, On Sun, 05 Jan 2014 14:28:14 +0100 Uli Schlachter <psyc...@znc.in> wrote:
> Hi, > [...] > > > >> Also, previously, the widget was centered in the space that was left over > >> from > >> the first and third widget and now it is centered inside of the align > >> layout. > >> > > > > That was my intention. It is to allow people to align something > > centered in the available space, something that was not easily doable > > before. The two other cases primarily serve that purpose. The "none" > > mode obeys all the fit function returns from the sub-widgets, so in > > that way, it is the closest to the old code. > > If it is desired to put something centered in the remaining space, > > that can be done too. The outer expand mode would be, "inside" and the > > center widget would be another align widget, expand mode of "none", > > and the only sub widget being the middle widget. > > The "outside" mode also centers the middle widget, but it forces the > > other two widgets to expand to fill the remaining space. > > > > Overall, I think the slightly changed behavior is more useful and less > > confusing, though the implementation might be a bit confusing. > > I just remembered that we are playing layout-ping-pong. Your "inside" mode > brings back the original behavior of the align layout. This was then changed > in > the following commit to the current behavior (CC'd the author): > > commit 8560de597c3a1f349907e6ef94cf343c86f63c30 > Author: Lukáš Hrázký <lukk...@email.cz> > Date: Sat Jan 5 16:12:50 2013 +0100 > > wibox.layout.align: make the middle widget really centered > > Centers the middle widget in the align layout in the remaining space > left by the widgets on the sides. > > Signed-off-by: Lukáš Hrázký <lukk...@email.cz> > Signed-off-by: Uli Schlachter <psyc...@znc.in> > > I also found the corresponding mailing list threads (there was a v2 of the > patches): > > http://www.mail-archive.com/awesome-devel@naquadah.org/msg07777.html > http://www.mail-archive.com/awesome-devel@naquadah.org/msg07855.html > > Lukáš: Could you take a look at these patches and comment on the new > behaviors? > After all, this would likely break your config by reverting the above change. > > I would provide links to them in the archives, but apparently gmane has DNS > issues and mail-archive didn't get the patches. Ask if you don't have the > patches. I'm still on the ML, I've been semi-watching this thread, but I'm rather busy these days and really need to work on something else. The layout stuff really is complicated and I'll have to try it out and stare at it for a while... I'll try to get to it, but I'm not sure it's gonna be before the next weekend. (I've got the patches.) I'm not entirely sure now, but I think I've changed the centering of the middle widget because it seemed to me like a better thing to do (ie. having no particular use-case). Imagine a big widget on the left and small on the right. If you then put a big widget in the middle, it may overlap with the left widget even though there is plenty of space to the right. cheers Lukas -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
