Hi Dmitry,
The fix looks good to me. One question though:
src/macosx/classes/sun/lwawt/macosx/CPlatformResponder.java
188 while (index < length) {
189 c = text.charAt(index);
190 peer.dispatchKeyEvent(KeyEvent.KEY_TYPED,
191 System.currentTimeMillis(),
192 0, KeyEvent.VK_UNDEFINED, c,
193 KeyEvent.KEY_LOCATION_UNKNOWN);
194 index++;
195 }
Are we sure we want to dispatch each character for the
handleInputEvent(String) event with its own timestamp? Does a browser
combine several unrelated key strokes into a single InputEvent, or are
all the characters actually represent one integral input event? Put
another way, should user code be able to see that a bunch of TYPED
events actually belongs to one native input event?
--
best regards,
Anthony
On 4/3/2012 3:40 PM, Dmitry Cherepanov wrote:
Hello,
Please review a fix for 7156194 ([macosx] Can't type non-ASCII
characters into applets)
http://cr.openjdk.java.net/~dcherepanov/7156194/8/webrev.0/
The patch is a direct forward-port of a fix from jdk7u-dev [1].
Thanks,
Dmitry
[1] http://hg.openjdk.java.net/jdk7u/jdk7u-dev/jdk/rev/7e97533153b8
