We don't need Apple to donate an Icon .. we can simply provide one for
OpenJDK (open) AND one for Oracle JDK (closed).
Jeff Hoffman is concocting a Duke one for OpenJDK
The build process can then simply determine which one to used based on
which build its doing
(Oracle or Open) as happens in a number of places. No need for a new
make variable.
-phil.
On 5/24/2012 7:49 PM, Scott Kovatch wrote:
On May 25, 2012, at 3:12 AM, Dalibor Topic<[email protected]> wrote:
On 5/23/12 5:41 PM, Phil Race wrote:
On 5/23/2012 8:25 AM, Henri Gomez wrote:
That seems like overkill to me. Can't we just put the .icns in the JRE
(Contents/Home/jre/lib/images) and load it from there? What are we guarding
against by putting it into a .h file?
OpenJDK will use Oracle icons ? Even for the community version ?
I was wondering about this too. It seems wrong. The icon, and/or the header file
should be in "closed".
Correct.
We do not put branded images in the open tree, no
matter how its encoded since they aren't open source.
Correct.
The openjdk should use something like the open source duke icon.
Or even better, no image by default in OpenJDK, with an ALT_ICON_DATA that can
be supplied to point
to the icon to use. That way we don't have to bikeshed about say following the
annual Duke fashion
trends, and yet people who want to add some open source icon to their builds
can do so.
Okay, let's get the facts out before we do anything crazy.
Java applications should have a Dock icon when running, so we don't use the
default application icon. Currently the AWT uses
/System/Library/Frameworks/JavaVM.framework/Resources/GenericApp.icns, which
means it's Apple's icon right now. Oracle would like to use its own icon.
OpenJDK (IMO) shouldn't rely on an icon in a framework that could disappear in
the next year or two, so it should use its own icon. The AWT will need to
change for that to happen. If Apple would like to donate this icon I think it
would be great, and would solve that problem nicely. It's then up to Leonid to
decide how to best use it.
Next, Oracle would like to override the default icon so it can use its own
icon. If OpenJDK would like to specify the path with a make variable that can
be overridden, I think that would solve that part of the problem as well.
Does this sound like a plan? Mike S., what do you think? Leonid, does this work
for you?
- Scott K.
