Re: [8] Review request for 7171412: awt Choice doesn't fire ItemStateChange when selecting item after select() call - approved

[Denis S. Fokin]

Hi Oleg,

the fix looks good. It was interesting to verify the functionality on 
Linux. On my Ubuntu everything works properly.

Thank you,
   Denis.

On 10/2/2012 6:48 PM, Artem Ananiev wrote:
Hi, Oleg,

the new version looks fine.

Thanks,

Artem

On 10/2/2012 4:30 PM, Oleg Pekhovskiy wrote:
Hi Artem,

thank you for the review, I made changes you proposed there:
http://cr.openjdk.java.net/~bagiras/8/7171412.2

Please tell if everything is ok.

Thanks,
Oleg

10/1/2012 2:23 PM, Artem Ananiev wrote:
Hi, Oleg,

(adding Tim to copy)

the fix looks fine. Could you please make selectedIndexID just a
static variable in awt_Choice.cpp instead of AwtChoice member?

Thanks,

Artem

On 10/1/2012 2:09 PM, Oleg Pekhovskiy wrote:
Hi!

Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171412

Webrev:
http://cr.openjdk.java.net/~bagiras/8/7171412.1/

I left the idea of the fix CR 6770017 but refused of using doubling
native variable for storing previously selected index
(that also caused the problem described in the current issue).

Thanks,
Oleg