The fix looks good for me.
Thanks,
Alexandr.
On 2/26/2013 5:45 PM, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk 8. Fix will be ported to jdk7 as well.
In the fix getScreenInsets() implementation was moved to the one
native method. I assume that it doesn't lead to incorrect nsscreen in
the middle of operations, if we run all appropriate operation in one
step on appkit thread. CFRetain/CFRelease are unnecessary in this case.
nativeGetDisplay** methods were changed to static, because in the
native they implemented as a static.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003169
Webrev can be found at:
http://cr.openjdk.java.net/~serb/8003169/webrev.00