On 10/04/2013 12:46 PM, Artem Ananiev wrote:
On 10/4/2013 12:24 PM, Anthony Petrov wrote:
The fix looks good to me.
+1.
I would also add a comment to security exception [empty] handler that we
don't really expect exceptions here: either we have the permission, or
the owner is not alwaysOnTop.
setAlwaysOnTop() throws a SecurityException regardless of its argument's
value. So the comment is not accurate. I'd leave the code as is - the
name "ignore" for the exception tells us all we need to know.
--
best regards,
Anthony
Thanks,
Artem
--
best regards,
Anthony
On 10/03/2013 05:03 PM, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-7081594
webrev: http://cr.openjdk.java.net/~alexsch/7081594/webrev.00
The fix:
- sets alwaysOnTop field for a new created window from the parent
value
- propagates the alwaysOnTop value in setAlwaysOnTop() method to
the owned windows
Thanks,
Alexandr.
