>> Hi David, >> >> The fix looks good to me. To answer your questions: >> >> 1. Using the XAWT macro is correct. It is only defined if we're building >> the XToolkit, which we don't on the Mac. However, everywhere else we >> actually check > > XAWT is a legacy macro, which was introduced to share code between XToolkit > and MToolkit on Linux/Solaris. At the moment, XAWT is always defined on > Linux/Solaris and never defined on Mac OS X, so checks against XAWT and > MACOSX are interchangeable. In the future, if we support anything besides X11 > on Linux/Solaris, XAWT may be of some use again, but MACOSX meaning is > unlikely to change. So my preference would be to use MACOSX rather than !XAWT.
Ok, I'll update the webrev. -DrD-
