Hi Anton,
Currently JFXPanel calls "checkPasteboard" via reflection. I had filed JDK-8061315 to provide a
public method instead. But with your fix it's not needed.
So, I've closed JDK-8061315. Also, I will back out the related fix in JFXPanel:
https://javafx-jira.kenai.com/browse/RT-38922
Thanks,
Anton.
On 30.03.2015 14:39, Sergey Bylokhov wrote:
The fix looks good.
I recall that checkPasteboard can be used outside of awt in fx. Anton T. can
clarify this.
26.03.15 20:32, Anton Nashatyrev wrote:
Hi Sergey,
yes it looks like I've missed the notifyChanged.
you are right, this will remove the unnecessary AWT upcall from Toolkit thread (was it your
intention?)
Please take a look at the new fix version (the test has also been updated to
check flavorsChanged):
http://cr.openjdk.java.net/~anashaty/8071668/9/webrev.01/
<http://cr.openjdk.java.net/%7Eanashaty/8071668/9/webrev.01/>
Thanks!
Anton.
On 26.03.2015 18:10, Sergey Bylokhov wrote:
Hi, Anton.
Should we call CClipboard.notifyChanged when the owner was changed?(at least
CClipboard.checkPasteboard call it). If yes then it seems that the previous fix(8010925) for
this bug can be reworked in pure java using checkPasteboardWithoutNotification?
26.03.15 17:29, Anton Nashatyrev wrote:
Hello,
could you please review the following fix:
fix: http://cr.openjdk.java.net/~anashaty/8071668/9/webrev.00/
<http://cr.openjdk.java.net/%7Eanashaty/8071668/9/webrev.00/>
bug: https://bugs.openjdk.java.net/browse/JDK-8071668
Problem: On Mac Java doesn't see external clipboard changes.
Fix: since there is still no Cocoa pasteboard changes notification mechanism, check the
Cocoa clipboard counter each time the contents is requested from the Java Clipboard.
Thanks!
Anton.
--
Best regards, Sergey.
--
Best regards, Sergey.
