I am not familiar with this code but I have a few comments anyway
1. I dislike cluttering the source with bug ids. If we did that for
every fix
quite soon the source code would be a mess of semi-random numbers.
Anyone who really wants to know when this change was made has the
history
2. if is not a function. So "if(" -> "if ("
3. When a marked text -> When marked text
4. "!" is not a "special character" .. its quite ordinary .. so what do
you mean ?
5. What testing have you done to make sure no other cases are broken by
this change ?
The new test is manual and I'd bet that most tests that might cover
this are manual
I'd expect to hear that you have tested different input scenarios
such as a couple
of input methods/locales, and AWT and Swing input with a
representative set of
input as well as running all the relevant regression tests.
-phil.
On 06/02/2017 07:48 AM, Sreeprakash Sreedharan wrote:
Hi All,
Kindly review the fix for JDK10.
Bug: https://bugs.openjdk.java.net/browse/JDK-8180370
Webrev: http://cr.openjdk.java.net/~rpatil/8180370/webrev.00/
Issue: Special characters (like !,/\<> ) were getting skipped when immediately
entered after a marked text on MacOSX.
Fix: Made sure that fKeyEventsNeeded flag is reset, when a non-marked text is
encountered, so that it doesn't get ignored by key down.
Note: Since the keyboard layout has to be changed to Korean, I have added a
manual test case wherein the user is prompted to change to Korean keyboard
layout and then execute the test.
Regards,
Sreeprakash
