Hi,
The changes look fine but I am obliged to ask some questions before
approving ..
My #1 question here, is how did you test this ?
Specifically I'd like to hear that this passes on all affected platforms
using the "blessed" compilers,
which in practice is most easily verified by submitting a job to our
(ahem) internal build systems.
And do you know if this will force usage of --disable-warnings on any
conmonly used compilers ?
Also due to the change of approach in defining shader programs you
really should
run some tests with the OGL pipeline too ..
-phil.
On 10/13/2017 11:20 AM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK10:
bug:https://bugs.openjdk.java.net/browse/JDK-8074824
webrev: http://cr.openjdk.java.net/~ssadetsky/8074824/webrev.00/
The eliminates gcc warnings produced during compilation of xawt library.
--Semyon
