Hi, Please find the modified Webrev to address this issue: http://cr.openjdk.java.net/~sveerabhadra/8193463/webrev.03/
Thanks and regards, Shashi -----Original Message----- From: Sergey Bylokhov Sent: Wednesday, January 17, 2018 10:49 PM To: Phil Race <[email protected]> Cc: [email protected] Subject: Re: <AWT Dev> [10] JDK-8193463: [TESTBUG] [PIT]: java/awt/TrayIcon/TrayIconPopup/TrayIconPopupClickTest.java fails I am not sure that we need to implement this change in this test, because all our TrayIcon tests which check events use the same approach. Probably we could document it, or mark them by some keyword. On 16/01/2018 22:34, Shashidhara Veerabhadraiah wrote: > Hi All, Please review a test only fix for a regression caused under > the original bug: https://bugs.openjdk.java.net/browse/JDK-8146537 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8193463 > > Webrev: http://cr.openjdk.java.net/~sveerabhadra/8193463/webrev.02/ > > Summary: The test created under the original bug assumes a certain > system setting which is not default under the windows platform though > it is a standard assumption for the tray icon related tests. Hence > this test is being converted to a manual test by adding a step to > change the system default setting before continuing the test. The > original bug fixes an issue with windows platform, hence this test is > made to test only on the windows platform. > > Thanks and regards, > Shashi > -- Best regards, Sergey.
