Hi, Igor. Thank you for review. Any volunteers for the second review? =)
On 10/10/2018 20:04, Igor Ignatyev wrote:
Hi Sergey, the changes in NSTexturedJFrame and 7154841 tests look good to me. -- IgorOn Oct 7, 2018, at 4:41 PM, Sergey Bylokhov <sergey.bylok...@oracle.com> wrote: Hello. Please review the fix for jdk12. Bug: Some tests fail after JDK-8210039 https://bugs.openjdk.java.net/browse/JDK-8211822 Bug: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS https://bugs.openjdk.java.net/browse/JDK-8202886 Webrev: http://cr.openjdk.java.net/~serb/8211822/webrev.00 These tests use the ExtendedRobot which is located in the library, but the fix for JDK-8210039 changed the path to the library, since it assumed only OSInfo was used there, and it missed ExtendedRobot. As a fix the "/test/jdk/lib/testlibrary/" library was added back. One of the test above fails, because of JDK-8202886, the root cause is the using of the shortcuts to iterate the global menu, which are not necessary configured or might be changed. As a fix the test will use mouse clicks. -- Best regards, Sergey.
-- Best regards, Sergey.
