Hi Sergey, Could you update the test use @requires tag, instead of relying on Platform for NSTexturedJFrame.java? This would probably make the test skip faster on non-Mac platforms.
Thanks, Krishna -----Original Message----- From: Jayathirth Rao Sent: Wednesday, October 31, 2018 12:25 PM To: Sergey Bylokhov <sergey.bylok...@oracle.com> Cc: awt-dev@openjdk.java.net; Igor Ignatyev <igor.ignat...@oracle.com> Subject: Re: <AWT Dev> [12] Review Request: 8211822 and 8202886 Changes are fine. Thanks, Jay > On 31-Oct-2018, at 12:19 PM, Sergey Bylokhov <sergey.bylok...@oracle.com> > wrote: > > HI, Jay. > > The fix is updated: > http://cr.openjdk.java.net/~serb/8211822/webrev.01 > - The lines which were added recently to the ProblemList, were removed. > - The typo in the bug4199622 was fixed. > > On 30/10/2018 03:46, Jayathirth D V wrote: >> Hi Sergey, >> Apart from 3 test cases updated, I am seeing failure of >> javax/swing/JComboBox/4199622/bug4199622.java also because of same reason. >> I raised JDK-8213122 and we actually updated ProblemList today to reflect >> these failures and after that I saw this RFR. >> We need to make similar change in >> javax/swing/JComboBox/4199622/bug4199622.java. Also please update >> ProblemList accordingly. >> I will close JDK-8213122 as duplicate of JDK-8211822. >> Thanks, >> Jay >> -----Original Message----- >> From: Sergey Bylokhov >> Sent: Tuesday, October 30, 2018 6:25 AM >> To: Igor Ignatyev >> Cc: awt-dev@openjdk.java.net >> Subject: Re: <AWT Dev> [12] Review Request: 8211822 and 8202886 Hi, >> Igor. >> Thank you for review. Any volunteers for the second review? =) On >> 10/10/2018 20:04, Igor Ignatyev wrote: >>> Hi Sergey, >>> >>> the changes in NSTexturedJFrame and 7154841 tests look good to me. >>> >>> -- Igor >>> >>>> On Oct 7, 2018, at 4:41 PM, Sergey Bylokhov <sergey.bylok...@oracle.com> >>>> wrote: >>>> >>>> Hello. >>>> Please review the fix for jdk12. >>>> >>>> Bug: Some tests fail after JDK-8210039 >>>> https://bugs.openjdk.java.net/browse/JDK-8211822 >>>> Bug: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS >>>> https://bugs.openjdk.java.net/browse/JDK-8202886 >>>> Webrev: http://cr.openjdk.java.net/~serb/8211822/webrev.00 >>>> >>>> These tests use the ExtendedRobot which is located in the library, but the >>>> fix for JDK-8210039 changed the path to the library, since it assumed only >>>> OSInfo was used there, and it missed ExtendedRobot. As a fix the >>>> "/test/jdk/lib/testlibrary/" library was added back. >>>> >>>> One of the test above fails, because of JDK-8202886, the root cause is the >>>> using of the shortcuts to iterate the global menu, which are not necessary >>>> configured or might be changed. As a fix the test will use mouse clicks. >>>> >>>> -- >>>> Best regards, Sergey. >>> > > > -- > Best regards, Sergey.
