Hi Dmitry, While I understand that you donot want to order the windows when the popup window is present as a child of the root window, I did not understand, why you need to check if the total number of windows should be only one. If I understand correctly, if a modal dialog/any other child window has a ComboBox component in it, then PopupMenu will be an additional window, and the length may not necessarily be equal to one.
Thanks, Krishna > On 21-Nov-2018, at 10:10 PM, Dmitry Markov <dmitry.mar...@oracle.com> wrote: > > Hello, > > Could you review a fix for jdk12, please? > > bug: https://bugs.openjdk.java.net/browse/JDK-8213983 > <https://bugs.openjdk.java.net/browse/JDK-8213983> > webrev: http://cr.openjdk.java.net/~dmarkov/8213983/webrev.00/ > <http://cr.openjdk.java.net/~dmarkov/8213983/webrev.00/> > > On OS X the keyboard shortcut “cmd +`” stops working properly if a popup > window is displayed. That behaviour is caused by window ordering operation. > However it is really unnecessary to perform ordering for popup windows > because they are located at another window level, (i.e. > NSPopUpMenuWindowLevel) and always placed above their parents. > > Thanks, > Dmitry
