Changes are fine. Thanks, Jay
> On 26-Nov-2019, at 10:55 AM, Prasanta Sadhukhan > <prasanta.sadhuk...@oracle.com> wrote: > > Hi All, > > Please review a fix for a compatibility issue introduced in JDK-8214578 where > a type alias NSTextInputSourceIdentifier is used which is only present from > osx10.13 onwards thereby breaking compatibility with osx10.12. > Fix is to use the typedef NSString * instead of which > NSTextInputSourceIdentifier is a type of > > Bug: https://bugs.openjdk.java.net/browse/JDK-8234786 > <https://bugs.openjdk.java.net/browse/JDK-8234786> > > diff -r b256c7afe8cc src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h > --- a/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h Mon Nov > 25 11:20:14 2019 +0530 > +++ b/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h Tue Nov > 26 10:49:47 2019 +0530 > @@ -38,7 +38,7 @@ > // TODO: NSMenu *contextualMenu; > > // Keyboard layout > - NSTextInputSourceIdentifier kbdLayout; > + NSString *kbdLayout; > > // dnd support (see AppKit/NSDragging.h, NSDraggingSource/Destination): > CDragSource *_dragSource; > > Regards > Prasanta
