Re: [14] RFR JDK-8234786: Fix for JDK-8214578 breaks OS X 10.12 compatibility

[Philip Race]

+1

-phil

On 11/25/19, 9:25 PM, Prasanta Sadhukhan wrote:

Hi All,

Please review a fix for a compatibility issue introduced in JDK-8214578 where a type alias NSTextInputSourceIdentifier is used which is only present from osx10.13 onwards thereby breaking compatibility with osx10.12. Fix is to use the typedef NSString * instead of which NSTextInputSourceIdentifier is a type of

Bug: https://bugs.openjdk.java.net/browse/JDK-8234786

diff -r b256c7afe8cc src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h --- a/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.hMon Nov 25 11:20:14 2019 +0530 +++ b/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.hTue Nov 26 10:49:47 2019 +0530

@@ -38,7 +38,7 @@
     // TODO: NSMenu *contextualMenu;


     // Keyboard layout
-    NSTextInputSourceIdentifier kbdLayout;
+    NSString *kbdLayout;

// dnd support (see AppKit/NSDragging.h, NSDraggingSource/Destination):

     CDragSource *_dragSource;

Regards
Prasanta