On Wed, 16 Dec 2020 18:03:19 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Creating a native peer for pushbutton accessibility role on Max OS X. >> The process of choosing of what peer to initialize is clunky so >> might be addressed in the future. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Moved the new components implementations to the separate files. > Changed the iitialization procedure to a class function with > dictionary of role to class name relation. > > This pr is still intermittent since it uses the old style > JNF java call syntacsis. Once fix for JDK-8257853 is integrated > the calls needs to be converted to the new style but that is a minor > change. src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ButtonAccessibility.m line 29: > 27: #import "ThreadUtilities.h" > 28: > 29: static JNF_STATIC_MEMBER_CACHE(jm_doAccessibleAction, > sjc_CAccessibility,"doAccessibleAction","(Ljavax/accessibility/AccessibleAction;ILjava/awt/Component;)V"); You can move this to the method itself, it is unlikely will be used outside of it, same as in the `perform()` ------------- PR: https://git.openjdk.java.net/jdk/pull/1549
