On Tue, 12 Jan 2021 06:04:32 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ButtonAccessibility.h >> line 25: >> >>> 23: * questions. >>> 24: */ >>> 25: >> >> There are no header guard here. Is it left intentionally? > > Yes, since the CommonComponentAccessibility being imported from the base > class sometimes it causes compilation glitches - guess ObjC is not a big fan > of forward-declaration. Adding header guard helps. And since i'm not planning > to include sub-component header files in the base classes the ifdef guard is > not required. The headers in the obj-c usually do not have guards because they are included via "#import" ------------- PR: https://git.openjdk.java.net/jdk/pull/1549
