On Wed, 16 Jun 2021 21:21:52 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Even on Linux? I meant if the test will be run on the platform where a11y
>> is not implemented then this will be
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java line 130:
>
>> 128: if (c != null) {
>> 129: try {
>> 130: value = EventQueue.isDispatchThread() ? callable.call()
>> : LWCToolkit.invokeAndWait(callable, c);
>
> When this method is called on EDT?
In the same class there is a getChildrenAndRolesRecursive () method that calls
invokeAndWait (), inside it it calls itself and getChildrenAndRoles (), which
also call invokeAndWait ().
> src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/NavigableTextAccessibility.m
> line 79:
>
>> 77: if (values == NULL) {
>> 78: // Note: Java will not be on the stack here so a java exception
>> can't happen and no need to call ExceptionCheck.
>> 79: NSLog(@"%s failed calling GetDoubleArrayElements", __FUNCTION__);
>
> Please clarify the comment above.
This comment has been carried over from the legacy code. it is still relevant.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4412
