On Fri, 20 Aug 2021 13:39:58 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added WindowListener to check Frame is opened and simplified the testcase
>
> test/jdk/java/awt/im/4959409/bug4959409.java line 59:
>
>> 57: private static JLabel jLabel;
>> 58:
>> 59: public static void createUIAndTest() throws InterruptedException,
>> InvocationTargetException, AWTException {
>
> `throws Exception` would be enough and shorter:
> Suggestion:
>
> public static void createUIAndTest() throws Exception {
>
>
> It's a test code, any exception means the test fails, so we don't care much
> about which specific exceptions can be thrown.
Okay
> test/jdk/java/awt/im/4959409/bug4959409.java line 80:
>
>> 78:
>> 79: jTextField.addKeyListener(new KeyAdapter() {
>> 80:
>
> I'd remove this blank line for consistency with the anonymous class above.
Done
> test/jdk/java/awt/im/4959409/bug4959409.java line 92:
>
>> 90: } else {
>> 91: jLabel.setText("Did not received keyPressed for
>> Shift+1");
>> 92: System.out.println("Did not received keyPressed
>> for Shift+1");
>
> The grammar:
> Suggestion:
>
> jLabel.setText("Did not receive keyPressed for
> Shift+1");
> System.out.println("Did not receive keyPressed for
> Shift+1");
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/5058
