On Fri, 20 Aug 2021 13:45:23 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> lawrence.andrews has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added WindowListener to check Frame is opened and simplified the testcase
>
> test/jdk/java/awt/im/4959409/bug4959409.java line 120:
>
>> 118: });
>> 119:
>> 120: clickTextField(robot, points[0].x + rect[0].width / 2,
>> points[0].y + rect[0].height / 2);
>
> I'd probably wrap this line, it doesn't fit even in 120 columns.
done
> test/jdk/java/awt/im/4959409/bug4959409.java line 131:
>
>> 129:
>> 130: if (!keyPressedEventLatch.await(TIMEOUT, TimeUnit.SECONDS)) {
>> 131: throw new RuntimeException("Did not received keyPressed for
>> Shift + 1 , test failed");
>
> The grammar:
> Suggestion:
>
> throw new RuntimeException("Did not receive keyPressed for Shift
> + 1 , test failed");
done
> test/jdk/java/awt/im/4959409/bug4959409.java line 147:
>
>> 145:
>> 146: public static void main(String[] args) throws InterruptedException,
>> InvocationTargetException,
>> 147: AWTException {
>
> Suggestion:
>
> public static void main(String[] args) throws Exception {
>
> Shorter.
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/5058
