[
http://issues.apache.org/jira/browse/AXIS2-761?page=comments#action_12413580 ]
Oleg Kalnichevski commented on AXIS2-761:
-----------------------------------------
Chuck,
Overall, the patch is okay with me. There is a couple of things I thought I
should mention
(1) HttpFactory: I am not a big fan of complex mega object factories used to
create all sorts of objects including other object factories. I would rather
prefer a simple configuration map containing only elemental values (Integer,
String, etc), where concrete implementation classes can be specified by a class
name. One should not have to override the HttpFactory just to drop in a custom
implementation of an abstract interface. I do admit this is a matter of taste,
though, so take it for what it is worth.
(2) There is a minor bug in HttpFactory
/** Setter for RequestCoreThreadPoolSize */
public void setRequestCoreThreadPoolSize(int RequestCoreThreadPoolSize) {
this.requestCoreThreadPoolSize = requestCoreThreadPoolSize;
}
I should probably be
/** Setter for RequestCoreThreadPoolSize */
public void setRequestCoreThreadPoolSize(int requestCoreThreadPoolSize) {
this.requestCoreThreadPoolSize = requestCoreThreadPoolSize;
}
(3) HttpServiceProcessor as a subclass HttpService may not be good enough. As I
mentioned before, HttpService has been written assuming a single thread of
execution per HTTP connection. If you want to implement a dispatch mechanism
intended to assign connections to different thread pools based on some
properties of an incoming HTTP request, HttpService simply may not cut it.
Cheers,
Oleg
> SimpleHttpServer based on Jakarta HttpComponents HttpCore
> ---------------------------------------------------------
>
> Key: AXIS2-761
> URL: http://issues.apache.org/jira/browse/AXIS2-761
> Project: Apache Axis 2.0 (Axis2)
> Type: Improvement
> Components: transports
> Versions: 1.0
> Reporter: Oleg Kalnichevski
> Attachments: ConfigurableSimpleHTTPServer.consolidated.patch,
> ConfigurableSimpleHTTPServer.patch, jakarta-httpcore-4.0-20060521.jar,
> simplehttpserver.patch
>
> The following patch replaces the SimpleHttpServer implementation based on the
> testing framework of Commons HttpClient 3.x with a one based on Jakarta
> HttpComponents HttpCore. Compiled against Axis2 trunk and HttpCore trunk
> * Removes all references to Commons HttpClient classes
> * Enables streaming of schema definitions and similar content
> * Improves content buffering of SOAP response
> * Improves handling of fault conditions and exception handling
> * Fixes a number of NPEs in AxisEngine
> * Improves performance and reliability of the HTTP transport
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
