Dims, I'll log the JIRAs and provide the patches.
Mj On 2/20/07, Davanum Srinivas <[EMAIL PROTECTED]> wrote:
Manoj, For Axis2 1.2 release, let's do #2 and #3. We could use your help in terms of patches :) Please log a enhancement request for #1 and #4 so that we don't forget. FYI, we don't have much time to get out the RC1... thanks, dims On 2/20/07, Manoj Khangaonkar <[EMAIL PROTECTED]> wrote: > Hi all, > > I observed a few issues with the useOrignalWSDL parameter. Let me list them > and if there is consensus I can provide the necessary patch. > > My understanding of the intended behavior is that if > > <parameter name="useOrignalWSDL"> true </parameter> > > is defined in services.xml, then any explicit .wsdl file that the user > packaged in the services.aar is returned , when user > queries for WSDL with a HTTP get such as > > http://localhost:8080/services/axis2/<servicename>?wsdl > > If useOriginalWSDL parameter is omitted or value is false, any packaged WSDL > is ignored and a generated WSDL is returned. > > > 1. So the default behaviour of the kernel is to return a generated WSDL - > as if useOrginalWSDL = false. This seems a little non-intuitive. If a user > explicitly deployed a WSDL file with his aar, chances are high that he wants > that WSDL to be used and not the generated one. Thus the default behaviour > should be useOrginalWSDL = true; in other words , if there is WSDL file in > the aar, and useOrignalWSDL is not defined - then use/return the WSDL file > in the aar. Defaulting to true is less work for everyone. > > > 2. When useOrignalWSDL = false and there is an explicit WSDL in the aar, the > query > > http://localhost:8080/services/axis2/<servicename>?wsdl > > returns a WSDL where the target namespace of the types section is from the > explicit WSDL. Some unnecessary > namespaces are declared as well. This is bug and should be fixed. > > 3. The code path for WSDL 20 does not check whether useOriginalWSDL is > true/false > > > 4. Lastly - is there a good use case of this parameter ? Unless there is, We > could remove this parameter without > losing any functionality. > > If the use added an explicit WSDL to the aar , then that should be > used/returned and if there is no WSDL, it should > be generated. > > If I have to add/change a parameter in services.xml and redeploy -- I can > add/remove WSDL and redeploy. > > > Mj > > > -- Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web Services Developers --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
