OK, I've done the refactoring to remove the redundant code. I still think the class is overlarge and addresses 2 separate concerns. Firstly, to add the wrapped operation schema stuff to the wsdl4j definition and second to process the wsdl4j model.
I don't really understand the wrapped operation schema stuff but would otherwise like to factor it out into a separate class so that the builder can focus on the second concern which I believe is the main reason for the class. If we could separate them out I think the class would be a lot more maintainable. Does anyone have the knowledge and inclination to do this? David On 20/02/07, David Illsley <[EMAIL PROTECTED]> wrote:
Thanks. The addressing related parts look ok... but that's not all I care about. There's still a bunch of redundant code in the file. I've started a refactor which I'll try to do in a number of stages to keep it easy to do and to review. David On 19/02/07, Amila Suriarachchi <[EMAIL PROTECTED]> wrote: > hi, > I reviewed the code once and fixed some bugs. specially with the > copyingextensibility elements. > it seems that I have missed the populate operation method. if you could, > David can you please have a review for addressing related parts? I reviewed > and tested for soap binding and related wsdl parts. > > -- > Amila Suriarachchi, > WSO2 Inc. -- David Illsley - IBM Web Services Development
-- David Illsley - IBM Web Services Development --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
