On 12/26/07, Glen Daniels <[EMAIL PROTECTED]> wrote: > Deepal Jayasinghe wrote: > > I just implemented and commit the initial implementation of the > > dynamic phase support > > :( > > I mentioned that I was working on this, didn't I? [1] It's always > unfortunate when there's duplicated work. If I'd known you were > planning to work on it, one of us could have saved some time or we could > have worked together to spec it out.
I did not plan to do that , however I got some free time and implemented that since we discussed that and wanted to have that for next release. And believe me it did not take that much of time it was less than 1 and half hours. So I commit the code and I do not see any problem with that ( I mean and any duplicate of work) . My work going to be duplicate if you have commit the code. > > I'll review your implementation, Deepal, but I think I want a little > more functionality. For instance, there may be multiple before/after > phases - if my phase needs to be before phase2 AND before phase3, what do you mean by this ? this is like I need to find a number which is less than 3 as well as less than 2 , and that can be simplified to I need to find a number which is less than 2 . So why do you want to have two before phases. And I do not think any one will look for such kind of complex use case , I know you can come up with one , but in Axis2 mailing list no one has ever asked for such kind of feature. > to be able to specify something like: > > <phase name="MyNewPhase" before="phase2,phase3" flow="in,out"/> I agree that some one can tell that he need to add the phase to both in and out flow , and that will be a simple fix to my implementation. > > Also, my implementation so far handles resolving constraints even after > a module has been deployed, so if one module has the above phase > declaration and there isn't a "phase2" yet, when the next module gets > deployed and defines "phase2", it will try to put it after "MyNewPhase" > (if it can't that's an error of course). This means that some orderings > for module deployment might not work, but we can grow the (currently > very simple) logic into a more complex total-ordering system if we need to. Let's implement this only if some USER ask for this :) , this is more work than any kind of user want. > > I'll get my stuff checked in ASAP, but if you're planning to do more > work in this area, please let me know beforehand? Nope I am not going to do any more changes. Thanks Deepal --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
