Glyn On Sat afternoon dims made some changes to SOAPHeader that included some of the code I wrote. That change is what's in 1.45 and probaly is why the diff against 1.43 has trouble. One of the changes I made was to eliminate duplicate code from getHeadersByActor() and findHeaderElements(). Dims left the duplicate code there. I don't know if it was an oversight or a conscious decision, but I'd recommend removing the duplicate code. I'll defer to you guys to decide what to do.
john -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]On Behalf Of Glyn Normington Sent: Monday, July 01, 2002 8:01 AM To: [EMAIL PROTECTED] Subject: Re: bugfixes John, I ran your testcase and it succeeded, so I presume that recent changes have addressed the bug you identified. Perhaps you'd care to eyeball the latest revision of SOAPHeader.java to make sure this is really the case. If it is not, please beef up your test and send another submission. Therefore I committed just the testcase (and the code in PackageTests to run it), after splitting some long lines as per our coding conventions [1] and replacing generic imports statements with explicit lists (a convention that Axis seems to have adopted, although I can't see where it is documented). Thanks again for your contribution! Glyn [1] http://jakarta.apache.org/site/source.html (2nd para. links to Sun's coding standards).
