XSP.pm comment error

[Michael Nachbaur]

Matt, et al.

There seems to be a tiny one-line bug in XSP.pm whereby it'll complain if it needs to output a comment. I haven't had time to track the problem down to it's fullest, but I believe it might have to do with my upgrading to XML::LibXML 1.53. Essentially, it looks like the XML::LibXML::Document::createComment method has changed. Here's a patch that, at least for me, fixes the problem.

--- /home/nachbaur/.cpan/build/AxKit-1.61/lib/Apache/AxKit/Language/XSP.pm Fri Feb 7 04:22:25 2003
+++ /usr/lib/perl5/site_perl/5.6.0/i386-linux/Apache/AxKit/Language/XSP.pm Tue Feb 18 10:11:02 2003
@@ -8,6 +8,7 @@
use Apache::AxKit::Exception;
use Apache::AxKit::Cache;
use Fcntl;
+use utf8;

use vars qw/@ISA/;

@@ -919,6 +920,13 @@
package AxKit::XSP::SAXParser;

use XML::LibXML 1.30;
+BEGIN
+{
+ if($XML::LibXML::VERSION >= 1.53) {
+ require XML::LibXML::Common;
+ XML::LibXML::Common->import( qw/ :libxml :encoding / );
+ }
+}

sub new {
my ($type, %self) = @_;
@@ -1130,7 +1138,7 @@

sub __mk_comment_node {
my ($document, $parent, $text) = @_;
- my $node = $document->createCommentNode($text);
+ my $node = $document->createComment($text);
$parent->appendChild($node);
}


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]